Always enable storage image usage for non-RTV 2D images #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows multisample resolves to be performed on resources which do not support render target usage. Signed-off-by: Philip Rebohle <[email protected]>
doitsujin
force-pushed
the
resolve-storage-image-usage
branch
from
5d9f7d8
to
396dd6a
Compare
2 tasks
|
Asked an NV dev and they suggested this won't change anything for them. |
| @@ -774,6 +774,16 @@ static HRESULT vkd3d_get_image_create_info(struct d3d12_device *device, | |||
| if (!(desc->Flags & D3D12_RESOURCE_FLAG_DENY_SHADER_RESOURCE) || desc->SampleDesc.Count > 1) | |||
| image_info->usage |= VK_IMAGE_USAGE_SAMPLED_BIT; | |||
|
|
|||
| /* Add storage image usage if the image cannot be rendered to, but may | |||
| * be used as a destination image for multisample resolves. */ | |||
| if (desc->Dimension == D3D12_RESOURCE_DIMENSION_TEXTURE2D && desc->SampleDesc.Count == 1 && | |||
There was a problem hiding this comment.
It should be safe to land this if we check for AMD or NVIDIA for now. I'm still concerned about e.g. Intel/Turnip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for multisample resolve in some cases, but this is scary and needs testing on a wide range of hardware.
Builds on #1805.